Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ui/base/ime/composition_text.cc

Issue 1825273002: Add more out of line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/composition_text.h ('k') | ui/native_theme/native_theme.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/ime/composition_text.h" 5 #include "ui/base/ime/composition_text.h"
6 6
7 namespace ui { 7 namespace ui {
8 8
9 CompositionText::CompositionText() { 9 CompositionText::CompositionText() {
10 } 10 }
11 11
12 CompositionText::CompositionText(const CompositionText& other) = default;
13
12 CompositionText::~CompositionText() { 14 CompositionText::~CompositionText() {
13 } 15 }
14 16
15 void CompositionText::Clear() { 17 void CompositionText::Clear() {
16 text.clear(); 18 text.clear();
17 underlines.clear(); 19 underlines.clear();
18 selection = gfx::Range(); 20 selection = gfx::Range();
19 } 21 }
20 22
21 void CompositionText::CopyFrom(const CompositionText& obj) { 23 void CompositionText::CopyFrom(const CompositionText& obj) {
22 Clear(); 24 Clear();
23 text = obj.text; 25 text = obj.text;
24 for (size_t i = 0; i < obj.underlines.size(); i++) { 26 for (size_t i = 0; i < obj.underlines.size(); i++) {
25 underlines.push_back(obj.underlines[i]); 27 underlines.push_back(obj.underlines[i]);
26 } 28 }
27 selection = obj.selection; 29 selection = obj.selection;
28 } 30 }
29 31
30 } // namespace ui 32 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/ime/composition_text.h ('k') | ui/native_theme/native_theme.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698