Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1825253002: Revert of Remove a bunch of NPAPI quirks and related support code (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
jam, dcheng, piman
CC:
chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_windowed_plugins
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a bunch of NPAPI quirks and related support code (patchset #1 id:80001 of https://codereview.chromium.org/1813143002/ ) Reason for revert: Speculative revert: could have broken Win8 GN build. See crbug.com/597032 Original issue's description: > Remove a bunch of NPAPI quirks and related support code > > BUG=493212 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/f8396023a9e38d3ec249cdf1f730e4b79cebbc7e > Cr-Commit-Position: refs/heads/master@{#382642} TBR=dcheng@chromium.org,jam@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493212 Committed: https://crrev.com/c2ec05d98bce21ef672e6775e6f682d41f945f4e Cr-Commit-Position: refs/heads/master@{#382684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1792 lines, -9 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +43 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M content/child/npapi/plugin_instance.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/child/npapi/plugin_instance.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/npapi/webplugin.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 5 chunks +98 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 7 chunks +740 lines, -0 lines 0 comments Download
A content/child/npapi/webplugin_ime_win.h View 1 chunk +184 lines, -0 lines 0 comments Download
A content/child/npapi/webplugin_ime_win.cc View 1 chunk +314 lines, -0 lines 0 comments Download
M content/child/plugin_messages.h View 2 chunks +31 lines, -0 lines 0 comments Download
M content/common/plugin_constants_win.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/common/plugin_constants_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 3 chunks +28 lines, -0 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 2 chunks +12 lines, -0 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 4 chunks +25 lines, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 8 chunks +101 lines, -3 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +52 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dgozman
Created Revert of Remove a bunch of NPAPI quirks and related support code
4 years, 9 months ago (2016-03-22 21:31:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825253002/1
4 years, 9 months ago (2016-03-22 21:32:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 21:33:24 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 21:35:35 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2ec05d98bce21ef672e6775e6f682d41f945f4e
Cr-Commit-Position: refs/heads/master@{#382684}

Powered by Google App Engine
This is Rietveld 408576698