Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 182523002: Land Recent QUIC Changes. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes. Allow running the test server in secure mode. Merge internal change: 62164374 https://codereview.chromium.org/181413007/ Implement special behaviors (closing and timing out) in the test server. Testing only. Merge internal change: 62158630 https://codereview.chromium.org/177293008/ Moving a preexisting DCHECK to a new and more helpful dfatal. Merge internal change: 62089588 https://codereview.chromium.org/181463007/ PACKET_NBYTE_GUID -> PACKET_NBYTE_CONNECTION_ID GUID->ConnectionId QuicGuid->QuicConnectionId guid->connection_id except for the dos proto, which I'm leaving alone for now. renaming quic guid to connection id. no functional change. Merge internal change: 62087636 https://codereview.chromium.org/181483006/ QUIC-local change to extend per-connection stats. Extending QuicConnectionStats to add two Cubic-related stats. Merge internal change: 61977906 https://codereview.chromium.org/177843017/ Implement an early retransmit timer in QUIC's TcpLossAlgorithm to replace immediate loss and retransmission. Merge internal change: 61976680 https://codereview.chromium.org/182083002/ Add a time based loss detection algorithm to QUIC that loses packets after 1.25RTTs and at least one nack. Merge internal change: 61975778 https://codereview.chromium.org/182063002/ QUIC test cleanup to always use MockLossAlgorithm in QuicConnectionTest. Merge internal change: 61972606 https://codereview.chromium.org/180783003/ Minor optimizations to QuicUnackedPacketMap and QuicSentPacketManager to improve load testing. Merge internal change: 61961987 https://codereview.chromium.org/181433007/ Cleanup: Rename http_message_test_utils.{h,cc,_test.cc} to http_message.{h,cc,_test.cc} This is how it should be named (defines/tests class HTTPMessage), and it's confusingly similar to the unrelated http_message_utils.h n/a (test only) Merge internal change: 61955207 https://codereview.chromium.org/181703005/ Test-only change to QuicConnectionTest to use MockLossAlgorithm instead of specific details of the TCP loss detection algorithm. Merge internal change: 61953382 https://codereview.chromium.org/181693005/ Add mock methods for SendBlocked and SendWindowUpdate in QuicConnection (test only) Merge internal change: 61945606 https://codereview.chromium.org/181973002/ Add SendWindowUpdate and SendBlocked methods to QuicConnection. Not used yet. Merge internal change: 61915742 https://codereview.chromium.org/181413005/ Start using the loss timeout in QuicSentPacketManager and add a mock implementation of the LossDetectionInterface for testing. Merge internal change: 61903890 https://codereview.chromium.org/181723003/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253899

Patch Set 1 #

Patch Set 2 : fixed rch's comments in Patch set 1 of CL 181463007 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1567 lines, -1380 lines) Patch
M net/net.gyp View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/congestion_control/cubic.h View 4 chunks +8 lines, -1 line 0 comments Download
M net/quic/congestion_control/cubic.cc View 5 chunks +34 lines, -6 lines 0 comments Download
M net/quic/congestion_control/cubic_test.cc View 5 chunks +56 lines, -3 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/loss_detection_interface.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +8 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +37 lines, -13 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 10 chunks +23 lines, -4 lines 0 comments Download
A + net/quic/congestion_control/time_loss_algorithm.h View 2 chunks +23 lines, -10 lines 0 comments Download
A + net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +34 lines, -21 lines 0 comments Download
A + net/quic/congestion_control/time_loss_algorithm_test.cc View 3 chunks +66 lines, -77 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.h View 4 chunks +12 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 1 12 chunks +34 lines, -14 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_stats.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/quic_connection_stats.cc View 2 chunks +8 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 41 chunks +137 lines, -75 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 12 chunks +68 lines, -58 lines 0 comments Download
M net/quic/quic_framer_test.cc View 164 chunks +315 lines, -306 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 8 chunks +24 lines, -23 lines 0 comments Download
M net/quic/quic_protocol.cc View 7 chunks +25 lines, -22 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +22 lines, -11 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +34 lines, -2 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_framer_peer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 5 chunks +23 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 10 chunks +20 lines, -12 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 4 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 8 chunks +32 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 8 chunks +32 lines, -29 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 3 chunks +15 lines, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 7 chunks +62 lines, -57 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 7 chunks +64 lines, -53 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 12 chunks +118 lines, -104 lines 0 comments Download
A + net/tools/quic/test_tools/http_message.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/tools/quic/test_tools/http_message.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/tools/quic/test_tools/http_message_test_utils.h View 1 chunk +0 lines, -133 lines 0 comments Download
D net/tools/quic/test_tools/http_message_test_utils.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 4 chunks +10 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-02-27 01:00:31 UTC) #1
Ryan Hamilton
lgtm
6 years, 9 months ago (2014-02-27 01:10:47 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-02-27 01:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/182523002/20001
6 years, 9 months ago (2014-02-27 01:14:54 UTC) #4
ramant (doing other things)
On 2014/02/27 01:10:47, Ryan Hamilton wrote: > lgtm Thanks very much Ryan, raman
6 years, 9 months ago (2014-02-27 01:17:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 06:54:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-02-27 06:54:04 UTC) #7
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-02-27 18:08:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/182523002/20001
6 years, 9 months ago (2014-02-27 18:08:52 UTC) #9
Ryan Hamilton
lgtm
6 years, 9 months ago (2014-02-27 18:53:29 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 19:39:47 UTC) #11
Message was sent while issue was closed.
Change committed as 253899

Powered by Google App Engine
This is Rietveld 408576698