Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5054)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java

Issue 1825213006: [Android] Hide metrics and crash reporting checkbox in non-official builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
index 14aa3c6551fe12d376c31f0c3857765ff9307717..5d847f0f63590ee1a44c57ebe25b577b0e4ebb0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
@@ -19,6 +19,7 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.ui.text.SpanApplier;
import org.chromium.ui.text.SpanApplier.SpanInfo;
@@ -54,14 +55,19 @@ public class ToSAndUMAFirstRunFragment extends FirstRunPage {
}
});
- int paddingStart = getResources().getDimensionPixelSize(R.dimen.fre_tos_checkbox_padding);
- ApiCompatibilityUtils.setPaddingRelative(mSendReportCheckBox,
- ApiCompatibilityUtils.getPaddingStart(mSendReportCheckBox) + paddingStart,
- mSendReportCheckBox.getPaddingTop(),
- ApiCompatibilityUtils.getPaddingEnd(mSendReportCheckBox),
- mSendReportCheckBox.getPaddingBottom());
-
- mSendReportCheckBox.setChecked(!getPageDelegate().isNeverUploadCrashDump());
+ if (ChromeVersionInfo.isOfficialBuild()) {
+ int paddingStart = getResources().getDimensionPixelSize(
+ R.dimen.fre_tos_checkbox_padding);
+ ApiCompatibilityUtils.setPaddingRelative(mSendReportCheckBox,
+ ApiCompatibilityUtils.getPaddingStart(mSendReportCheckBox) + paddingStart,
+ mSendReportCheckBox.getPaddingTop(),
+ ApiCompatibilityUtils.getPaddingEnd(mSendReportCheckBox),
+ mSendReportCheckBox.getPaddingBottom());
+
+ mSendReportCheckBox.setChecked(!getPageDelegate().isNeverUploadCrashDump());
+ } else {
+ mSendReportCheckBox.setVisibility(View.GONE);
+ }
mTosAndPrivacy.setMovementMethod(LinkMovementMethod.getInstance());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698