Issue 1825213004: Fix //runtime/vm/BUILD.gn for typed_data library update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1825213004: Fix //runtime/vm/BUILD.gn for typed_data library update (Closed)

Created:
4 years, 9 months ago by zra

Modified:
4 years, 9 months ago

Reviewers:
Florian Schneider, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -27 lines)			Patch
	M	runtime/vm/BUILD.gn	View		4 chunks	+32 lines, -27 lines	0 comments	Download

Total messages: 7 (3 generated)

zra

Committed patchset #1 (id:1) manually as a414043ce3e6d10ecbb27ffa50b05fb7f41ee754 (presubmit successful).

4 years, 9 months ago (2016-03-23 19:56:07 UTC) #5

Florian Schneider

4 years, 9 months ago (2016-03-25 05:32:25 UTC) #7

Message was sent while issue was closed.

Thanks for fixing this. I was not aware that this breaks the gn build.