Issue 18252002: Revert "parseHTMLInteger shouldn't bloatCharacters()"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18252002: Revert "parseHTMLInteger shouldn't bloatCharacters()" (Closed)

Created:
7 years, 5 months ago by esprehn

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "parseHTMLInteger shouldn't bloatCharacters()" This reverts commit e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e (r153193) Looks like it's causing asserts: STDERR: ASSERTION FAILED: !isParsingFragment() || !tagName.matches(htmlTag) STDERR: ../../third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp(1651) : void WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately() TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153280

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/parser/HTMLParserIdioms.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

esprehn

Committed patchset #1 manually as r153280 (presubmit successful).

7 years, 5 months ago (2013-06-29 01:16:56 UTC) #1

Message was sent while issue was closed.

Thanks.

Expand Messages | Collapse Messages