Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1825183002: gpu_process_launch_causes => content/common (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
dcheng, piman
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_process_launch_causes => content/common This is used to establish the channel and has content-speciifc concepts. This doesn't seem to belong to content/common/gpu as per piman@'s suggestion. BUG=596290 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/c28d985e1f60cece099c984f1e1f8cd0c33c0e14 Cr-Commit-Position: refs/heads/master@{#382724}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -57 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu/gpu_process_launch_causes.h View 1 chunk +0 lines, -35 lines 0 comments Download
A + content/common/gpu_process_launch_causes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
Fady Samuel
+piman@ for overall review. +dcheng@ for messages
4 years, 9 months ago (2016-03-22 18:34:01 UTC) #2
piman
lgtm
4 years, 9 months ago (2016-03-22 18:35:43 UTC) #3
dcheng
lgtm
4 years, 9 months ago (2016-03-22 18:37:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825183002/1
4 years, 9 months ago (2016-03-22 18:44:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/7789) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-22 18:47:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825183002/20001
4 years, 9 months ago (2016-03-22 19:21:18 UTC) #11
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_widget_host_view_android.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-22 20:30:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825183002/60001
4 years, 9 months ago (2016-03-22 21:03:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825183002/60001
4 years, 9 months ago (2016-03-22 21:52:26 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-22 23:05:11 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 23:07:17 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c28d985e1f60cece099c984f1e1f8cd0c33c0e14
Cr-Commit-Position: refs/heads/master@{#382724}

Powered by Google App Engine
This is Rietveld 408576698