Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 182513003: Remove m_domDataStoreList from V8PerIsolateData (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, gavinp+loader_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Remove m_domDataStoreList from V8PerIsolateData - This CL removes V8PerIsolateData::m_domDataStoreList and related methods. - The only customer of these methods is SerializedScriptValue::neuterBinding(). This CL replaces it to use DOMWrapperWorld::allWorldsInMainThread() instead. BUG=341032 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168347

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M Source/bindings/v8/DOMDataStore.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 2 3 3 chunks +15 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 1 2 3 4 2 chunks +0 lines, -16 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
haraken
PTAL https://codereview.chromium.org/182513003/diff/2/Source/bindings/v8/SerializedScriptValue.cpp File Source/bindings/v8/SerializedScriptValue.cpp (left): https://codereview.chromium.org/182513003/diff/2/Source/bindings/v8/SerializedScriptValue.cpp#oldcode2339 Source/bindings/v8/SerializedScriptValue.cpp:2339: v8::Handle<v8::Object> wrapper = allStores[i]->get<V8ArrayBuffer>(object, isolate); This CL keeps ...
6 years, 10 months ago (2014-02-27 05:00:51 UTC) #1
dcarney
lgtm https://codereview.chromium.org/182513003/diff/2/Source/bindings/v8/SerializedScriptValue.cpp File Source/bindings/v8/SerializedScriptValue.cpp (left): https://codereview.chromium.org/182513003/diff/2/Source/bindings/v8/SerializedScriptValue.cpp#oldcode2339 Source/bindings/v8/SerializedScriptValue.cpp:2339: v8::Handle<v8::Object> wrapper = allStores[i]->get<V8ArrayBuffer>(object, isolate); On 2014/02/27 05:00:51, ...
6 years, 10 months ago (2014-02-27 07:20:50 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years, 9 months ago (2014-02-27 09:09:13 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-02-27 10:55:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/182513003/30001
6 years, 9 months ago (2014-02-27 10:55:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 11:52:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-02-27 11:52:23 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 13:10:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/182513003/50001
6 years, 9 months ago (2014-03-03 13:11:22 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 16:52:48 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24617
6 years, 9 months ago (2014-03-03 16:52:49 UTC) #11
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 23:17:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/182513003/50001
6 years, 9 months ago (2014-03-03 23:18:42 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 23:18:47 UTC) #14
commit-bot: I haz the power
Failed to apply the patch. <?xml version="1.0"?> <status> <target path=".">
6 years, 9 months ago (2014-03-03 23:18:47 UTC) #15
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 00:49:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/182513003/70001
6 years, 9 months ago (2014-03-04 00:49:17 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 00:49:30 UTC) #18
Message was sent while issue was closed.
Change committed as 168347

Powered by Google App Engine
This is Rietveld 408576698