[interpreter] Fix and test for printing of bytecodes.

[interpreter] Fix and test for printing of bytecodes.

BUG=v8:4280, v8:4747
LOG=N

Committed: https://crrev.com/afd2d68db92e4ecdd5d65c1bc0e6ff8969d24cf8
Cr-Commit-Position: refs/heads/master@{#35024}

[oth, 2016-03-22 16:40:33]

The CQ bit was checked by oth@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 16:40:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825103002/1

[oth, 2016-03-22 16:42:19]

oth@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[oth, 2016-03-22 16:42:19]

Ross, PTAL.

During the introduction of OperandScale, printing bytecodes broke and it was
missed. Fixed and added a basic test.

Thx

[rmcilroy, 2016-03-22 17:15:37]

LGTM, thanks for the test!

https://codereview.chromium.org/1825103002/diff/20001/test/unittests/interpre...
File test/unittests/interpreter/bytecodes-unittest.cc (right):

https://codereview.chromium.org/1825103002/diff/20001/test/unittests/interpre...
test/unittests/interpreter/bytecodes-unittest.cc:219: std::ios ios_fmt(nullptr);
nit - default_format  ?

https://codereview.chromium.org/1825103002/diff/20001/test/unittests/interpre...
test/unittests/interpreter/bytecodes-unittest.cc:221: expected_ss.fill('0');
nit - newline, and a comment to explain what this is doing (setting formatting
used to write out the prepending raw bytes of the bytecode).

[oth, 2016-03-23 10:10:06]

Thanks.

https://codereview.chromium.org/1825103002/diff/20001/test/unittests/interpre...
File test/unittests/interpreter/bytecodes-unittest.cc (right):

https://codereview.chromium.org/1825103002/diff/20001/test/unittests/interpre...
test/unittests/interpreter/bytecodes-unittest.cc:219: std::ios ios_fmt(nullptr);
On 2016/03/22 17:15:37, rmcilroy wrote:
> nit - default_format  ?

Done.

[oth, 2016-03-23 10:13:08]

The CQ bit was checked by oth@chromium.org

[oth, 2016-03-23 10:13:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1825103002/#ps40001
(title: "Additional checks, incorporate comments.")

[commit-bot: I haz the power, 2016-03-23 10:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825103002/40001

[commit-bot: I haz the power, 2016-03-23 10:23:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-23 10:23:57]

Description was changed from

==========
[interpreter] Fix and test for printing of bytecodes.

BUG=v8:4280,v8:4747
LOG=N
==========

to

==========
[interpreter] Fix and test for printing of bytecodes.

BUG=v8:4280,v8:4747
LOG=N

Committed: https://crrev.com/afd2d68db92e4ecdd5d65c1bc0e6ff8969d24cf8
Cr-Commit-Position: refs/heads/master@{#35024}
==========

[commit-bot: I haz the power, 2016-03-23 10:23:58]

Patchset 3 (id:??) landed as
https://crrev.com/afd2d68db92e4ecdd5d65c1bc0e6ff8969d24cf8
Cr-Commit-Position: refs/heads/master@{#35024}

[Michael Achenbach, 2016-03-23 16:04:35]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-03-23 16:04:36]

Looks like this is strangely flaky on asan:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN

Please disable the test for asan for now as it blocks clusterfuzz upload.

[Michael Achenbach, 2016-03-23 16:04:59]

cc cbruni