Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1825093002: [counters] adding runtime call timers for GC (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] adding runtime call timers for GC Adding an additional timer for the GC to make the other runtime call counters more stable. BUG= Committed: https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af Cr-Commit-Position: refs/heads/master@{#35033}

Patch Set 1 #

Patch Set 2 : adding gc timer #

Total comments: 2

Patch Set 3 : avoid direct use of the runtime call timer #

Patch Set 4 : adding additional GCTracer timer scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.h View 1 2 3 4 chunks +5 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 4 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Camillo Bruni
PTAL
4 years, 9 months ago (2016-03-22 16:00:56 UTC) #2
Camillo Bruni
PTAL again https://codereview.chromium.org/1825093002/diff/20001/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1825093002/diff/20001/src/heap/gc-tracer.h#newcode155 src/heap/gc-tracer.h:155: RuntimeCallTimer timer_; RuntimeCallTimer is a 3 word ...
4 years, 9 months ago (2016-03-23 13:54:02 UTC) #3
ulan
https://codereview.chromium.org/1825093002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1825093002/diff/20001/src/heap/heap.cc#newcode1012 src/heap/heap.cc:1012: RuntimeCallTimerScope timer( Please move this to GcTracer::Start / Stop ...
4 years, 9 months ago (2016-03-23 13:59:56 UTC) #4
Camillo Bruni
PTAL again
4 years, 9 months ago (2016-03-23 14:30:01 UTC) #5
ulan
lgtm
4 years, 9 months ago (2016-03-23 14:35:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825093002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825093002/60001
4 years, 9 months ago (2016-03-23 14:39:43 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-23 15:04:01 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af Cr-Commit-Position: refs/heads/master@{#35033}
4 years, 9 months ago (2016-03-23 15:04:30 UTC) #11
Michael Achenbach
4 years, 9 months ago (2016-03-23 15:37:28 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1827563003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] ASAN bot is really badass today:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10844.

Powered by Google App Engine
This is Rietveld 408576698