Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1825083002: PPC: [es6] Faster implementation of OrdinaryHasInstance. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Faster implementation of OrdinaryHasInstance. Port b6419fa2298de8e292c6bed0bd20de5c96f7da12 Original commit message: Now implemented as a builtin that delegates to the InstanceOfStub. That stub was parameterized to fallback to either Runtime_InstanceOf or to Runtime_OrdinaryHasInstance depending on the --harmony-instanceof flag. Once the feature stabilizes and the flag is no longer needed, we can get rid of this parameterization again. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4447 LOG=n Committed: https://crrev.com/46471067ff0bb7b48845f2a0c871fb75a82fecfb Cr-Commit-Position: refs/heads/master@{#34997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-22 15:27:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825083002/1
4 years, 9 months ago (2016-03-22 15:28:05 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 9 months ago (2016-03-22 15:29:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 15:56:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825083002/1
4 years, 9 months ago (2016-03-22 16:35:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:38:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:40:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46471067ff0bb7b48845f2a0c871fb75a82fecfb
Cr-Commit-Position: refs/heads/master@{#34997}

Powered by Google App Engine
This is Rietveld 408576698