Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 1825033002: Revert of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (Closed)

Created:
4 years, 9 months ago by blundell
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (patchset #1 id:1 of https://codereview.chromium.org/1817523003/ ) Reason for revert: Speculative revert to see if it fixes edit-dom-actions.html on Win7 webkit bots, which started timing out with no useful output on both Oilpan and non-Oilpan on runs including this CL (e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5007). Original issue's description: > DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. > > BUG=587982 > > Committed: https://crrev.com/ee50736c96ca97939d5b99543f3e0b297fd88029 > Cr-Commit-Position: refs/heads/master@{#382325} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587982 Committed: https://crrev.com/6592b9dbd6050a2e7b9f9f0174dc133d4647309b Cr-Commit-Position: refs/heads/master@{#382556}

Patch Set 1 #

Messages

Total messages: 3 (1 generated)
blundell
Created Revert of DevTools: Select max resource size in NetworkResourcesData depending on device capabilities.
4 years, 9 months ago (2016-03-22 12:17:59 UTC) #1
blundell
4 years, 9 months ago (2016-03-22 15:08:35 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1821103003/ by blundell@chromium.org.

The reason for reverting is: Reland the original CL as it's not the culprit (
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Win...,
which includes the revert, still has the test failure).

Powered by Google App Engine
This is Rietveld 408576698