Fix integer truncation in Character test functions

Fix integer truncation in Character test functions

The test functions checking for treatAs*Space and
isNormalizedCanvasSpaceCharacter were using UChar parameter
types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the space-tester
functions. If the truncated value matches in one of those, they
get blanked out with a space in the normalization step in
HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii

Committed: https://crrev.com/3f51d6256864b298b15feb93a57c6d986474245a
Cr-Commit-Position: refs/heads/master@{#382569}

[drott, 2016-03-22 12:05:14]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 12:05:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825023002/1

[drott, 2016-03-22 12:09:34]

Remove pragmas

[drott, 2016-03-22 12:10:02]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 12:10:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825023002/20001

[drott, 2016-03-22 12:11:28]

Description was changed from

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space were using UChar parameter
types, while they were used with UChar32 arguments in
HarfBuzzShaper.cpp.

This leads to characters being truncated, equivalent to being masekd
with 0xFFFF befor they go into the treatAs*Space testing functions. If
the truncated value matches in one of those, they get blanked out with a
space in the normalization step in HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii

tests
==========

to

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space were using UChar
parameter types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the treatAs*Space
testing functions. If the truncated value matches in one of
those, they get blanked out with a space in the normalization
step in HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii
==========

[drott, 2016-03-22 12:18:45]

Add test for isNormalizedCanvasSpaceCharacter

[drott, 2016-03-22 12:19:01]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 12:19:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825023002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825023002/2

[drott, 2016-03-22 12:20:06]

Description was changed from

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space were using UChar
parameter types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the treatAs*Space
testing functions. If the truncated value matches in one of
those, they get blanked out with a space in the normalization
step in HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii
==========

to

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space and
isNormalizedCanvasSpaceCharacter were using UChar parameter
types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the space-tester
functions. If the truncated value matches in one of those, they
get blanked out with a space in the normalization step in
HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii
==========

[kojii, 2016-03-22 13:10:38]

lgtm, great finding!

[drott, 2016-03-22 13:46:25]

The CQ bit was unchecked by drott@chromium.org

[drott, 2016-03-22 13:46:28]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2016-03-22 13:46:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825023002/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825023002/2

[commit-bot: I haz the power, 2016-03-22 14:32:48]

Committed patchset #3 (id:2)

[commit-bot: I haz the power, 2016-03-22 14:34:51]

Description was changed from

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space and
isNormalizedCanvasSpaceCharacter were using UChar parameter
types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the space-tester
functions. If the truncated value matches in one of those, they
get blanked out with a space in the normalization step in
HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii
==========

to

==========
Fix integer truncation in Character test functions

The test functions checking for treatAs*Space and
isNormalizedCanvasSpaceCharacter were using UChar parameter
types, while they were used with UChar32 arguments in
HarfBuzzShaper.

This leads to characters being truncated, equivalent to being
masekd with 0xFFFF, before they get passed to the space-tester
functions. If the truncated value matches in one of those, they
get blanked out with a space in the normalization step in
HarfBuzzShaper.

BUG=595960
R=pdr,eae,kojii

Committed: https://crrev.com/3f51d6256864b298b15feb93a57c6d986474245a
Cr-Commit-Position: refs/heads/master@{#382569}
==========

[commit-bot: I haz the power, 2016-03-22 14:34:53]

Patchset 3 (id:??) landed as
https://crrev.com/3f51d6256864b298b15feb93a57c6d986474245a
Cr-Commit-Position: refs/heads/master@{#382569}