Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: ui/gfx/ipc/gfx_ipc.gyp

Issue 1824993004: Separate gfx_ipc into skia-dependent and non-skia-dependent parts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/ipc/gfx_ipc.gyp
diff --git a/ui/gfx/ipc/gfx_ipc.gyp b/ui/gfx/ipc/gfx_ipc.gyp
index 80e1947bea24c807df626646dc5b3aa188ca3685..7be6b2208086fa8a7302bc272f22eca4ac33e4ac 100644
--- a/ui/gfx/ipc/gfx_ipc.gyp
+++ b/ui/gfx/ipc/gfx_ipc.gyp
@@ -14,7 +14,6 @@
'dependencies': [
'../../../base/base.gyp:base',
'../../../ipc/ipc.gyp:ipc',
- '../../../skia/skia.gyp:skia',
'../gfx.gyp:gfx',
'../gfx.gyp:gfx_geometry',
],
@@ -30,5 +29,28 @@
'gfx_param_traits_macros.h',
],
},
+ {
+ # GN version: //ui/gfx/ipc:skia_ipc
danakj 2016/03/29 19:47:31 Still correct? I think you have this in gyp twice
Mark Dittmer 2016/03/30 22:04:41 Thanks! Fixed.
+ 'target_name': 'gfx_ipc_skia',
+ 'type': '<(component)',
+ 'dependencies': [
+ '../../../base/base.gyp:base',
+ '../../../ipc/ipc.gyp:ipc',
+ '../../../skia/skia.gyp:skia',
+ '../gfx.gyp:gfx',
+ '../gfx.gyp:gfx_geometry',
+ 'gfx_ipc',
+ ],
+ 'defines': [
+ 'GFX_SKIA_IPC_IMPLEMENTATION',
+ ],
+ 'include_dirs': [
+ '../../..',
+ ],
+ 'sources': [
+ 'gfx_skia_param_traits.cc',
+ 'gfx_skia_param_traits.h',
+ ],
+ },
],
}

Powered by Google App Engine
This is Rietveld 408576698