Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1824983003: SkRecord: infer return type for visit() and mutate(). (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRecord: infer return type for visit() and mutate(). Committed: https://skia.googlesource.com/skia/+/343a63d082bda969d7e8a4e09ba850e931185269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M dm/DMSrcSink.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkBigPicture.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkRecord.h View 3 chunks +13 lines, -17 lines 0 comments Download
M src/core/SkRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkRecordPattern.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordTestUtils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/DumpRecord.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824983003/1
4 years, 9 months ago (2016-03-22 18:24:30 UTC) #3
mtklein_C
4 years, 9 months ago (2016-03-22 18:24:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 18:44:37 UTC) #7
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-22 18:45:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824983003/1
4 years, 9 months ago (2016-03-22 18:45:56 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 18:46:57 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/343a63d082bda969d7e8a4e09ba850e931185269

Powered by Google App Engine
This is Rietveld 408576698