Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1824933005: MediaStreamTrack: don't wait to record MediaStreamTrack's whose state is not 'live' (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
Reviewers:
Niklas Enbom
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaStreamTrack: don't wait to record MediaStreamTrack's whose state is not 'live' A MSTrack on which stop() has been called has state 'ended'. With this CL MR avoids waiting for those Tracks. BUG=596178 TEST= See bug #1: Steps to reproduce: 1- Go to https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html (note: needs either --enable-blink-features=GetUserMedia flag or chrome://flags -> Experimental Web Platform features enabled) 2- Click on GetUserMedia 3- Click on StopLocalAudioTracks to disable all audio tracks. 4- Click on CreateRecorder 5- Click on Start Committed: https://crrev.com/2181b9dfb8af9622a2a87afda9bbc10717721f0b Cr-Commit-Position: refs/heads/master@{#382697}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mcasas
niklase@ PTAL
4 years, 9 months ago (2016-03-22 21:31:52 UTC) #2
Niklas Enbom
Tested? TEST=Load https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html, click GetUserMedia, StoplocalAudioTracks, CreateRecorder,Start On 2016/03/22 21:31:52, mcasas wrote: > niklase@ PTAL
4 years, 9 months ago (2016-03-22 21:36:30 UTC) #4
mcasas
niklase@: tested as described and working. PTAL
4 years, 9 months ago (2016-03-22 21:48:58 UTC) #7
Niklas Enbom
lgtm On 2016/03/22 21:48:58, mcasas wrote: > niklase@: tested as described and working. > PTAL
4 years, 9 months ago (2016-03-22 21:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824933005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824933005/20001
4 years, 9 months ago (2016-03-22 21:55:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-22 22:00:53 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:03:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2181b9dfb8af9622a2a87afda9bbc10717721f0b
Cr-Commit-Position: refs/heads/master@{#382697}

Powered by Google App Engine
This is Rietveld 408576698