Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1824933002: include safe_browsing_db/util.h directly in files not related to chunking (Closed)

Created:
4 years, 9 months ago by vakh (use Gerrit instead)
Modified:
4 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, gavinp+prer_chromium.org, grt+watch_chromium.org, tburkard+watch_chromium.org, kcarattini
Base URL:
https://chromium.googlesource.com/chromium/src.git@v4_01_prot_mgr_basic_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include safe_browsing_db/util.h directly in files not related to chunking BUG=543161 Committed: https://crrev.com/fa183faf88675560951d0be353291218c6df48aa Cr-Commit-Position: refs/heads/master@{#383755}

Patch Set 1 #

Patch Set 2 : git fetch && git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/extensions/blacklist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/fake_safe_browsing_database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/ui_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/ui_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (9 generated)
vakh (use Gerrit instead)
4 years, 9 months ago (2016-03-22 01:14:45 UTC) #2
kcarattini
Have you removed safe_browsing_util.h entirely? Or is it still being used for something? Kendra
4 years, 9 months ago (2016-03-22 01:18:34 UTC) #4
vakh (use Gerrit instead)
On 2016/03/22 at 01:18:34, kcarattini wrote: > Have you removed safe_browsing_util.h entirely? Or is it ...
4 years, 9 months ago (2016-03-22 01:20:12 UTC) #5
Nathan Parker
lgtm Just add a little more context in the CL subj+description. thx
4 years, 9 months ago (2016-03-24 19:10:01 UTC) #6
vakh (use Gerrit instead)
4 years, 9 months ago (2016-03-25 23:29:15 UTC) #7
vakh (use Gerrit instead)
On 2016/03/24 19:10:01, Nathan Parker wrote: > lgtm > > Just add a little more ...
4 years, 9 months ago (2016-03-25 23:29:55 UTC) #9
vakh (use Gerrit instead)
git fetch && git rebase
4 years, 9 months ago (2016-03-26 00:44:07 UTC) #10
vakh (use Gerrit instead)
mmenke@chromium.org: Please review changes in chrome/browser/prerender/prerender_browsertest.cc benwells@chromium.org: Please review changes in chrome/browser/extensions/blacklist.cc chrome/browser/extensions/fake_safe_browsing_database_manager.cc
4 years, 9 months ago (2016-03-26 00:51:00 UTC) #13
mmenke
On 2016/03/26 00:51:00, vakh wrote: > mailto:mmenke@chromium.org: Please review changes in > chrome/browser/prerender/prerender_browsertest.cc > > ...
4 years, 8 months ago (2016-03-28 14:57:23 UTC) #14
benwells
c/b/e lgtm
4 years, 8 months ago (2016-03-29 06:41:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824933002/20001
4 years, 8 months ago (2016-03-29 16:25:33 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 17:33:46 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:36:15 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa183faf88675560951d0be353291218c6df48aa
Cr-Commit-Position: refs/heads/master@{#383755}

Powered by Google App Engine
This is Rietveld 408576698