Revert of media: Stop flushing the renderer for pipeline suspend

Revert of media: Stop flushing the renderer for pipeline suspend (patchset #2 id:20001 of https://codereview.chromium.org/1815423002/ )

Reason for revert:
This hit a CHECK in PipelineIntegrationTest.SuspendWhilePlaying

[12876:12876:0321/173811:1285613567:FATAL:ffmpeg_demuxer.cc(592)] Check failed: read_cb_.is_null(). Overlapping reads are not supported

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%281%29/builds/41437

This was something we didn't consider and probably can't be relanded without a fair amount of work.

Original issue's description:
> media: Stop flushing the renderer for pipeline suspend
>
> Previously when performing a pipeline suspend we would flush the
> renderer before destructing it. This CL removes the flush because
> it's no longer necessary and has issues:
> 1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
>    a difference for fullscreen transitions), and
> 2) on <API level 18 devices it will cause AVDA to go into an
>    error state when it handles the flush by creating a new
>    MediaCodec without a valid output surface.
>
> BUG=596641, 595545
> TEST=media_unittests
>
> Committed: https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7
> Cr-Commit-Position: refs/heads/master@{#382417}

TBR=sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596641, 595545
Committed: https://crrev.com/4c88276f8f1fdcb0a921bfb979e22cd2acf241bb
Cr-Commit-Position: refs/heads/master@{#382465}

[watk, 2016-03-22 00:56:21]

Created Revert of media: Stop flushing the renderer for pipeline suspend

[commit-bot: I haz the power, 2016-03-22 00:56:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824923002/1

[commit-bot: I haz the power, 2016-03-22 00:57:07]

Description was changed from

==========
Revert of media: Stop flushing the renderer for pipeline suspend (patchset #2
id:20001 of https://codereview.chromium.org/1815423002/ )

Reason for revert:
This hit a CHECK in PipelineIntegrationTest.SuspendWhilePlaying

[12876:12876:0321/173811:1285613567:FATAL:ffmpeg_demuxer.cc(592)] Check failed:
read_cb_.is_null(). Overlapping reads are not supported

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28...

This was something we didn't consider and probably can't be relanded without a
fair amount of work.

Original issue's description:
> media: Stop flushing the renderer for pipeline suspend
> 
> Previously when performing a pipeline suspend we would flush the
> renderer before destructing it. This CL removes the flush because
> it's no longer necessary and has issues:
> 1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
>    a difference for fullscreen transitions), and
> 2) on <API level 18 devices it will cause AVDA to go into an
>    error state when it handles the flush by creating a new
>    MediaCodec without a valid output surface.
> 
> BUG=596641,595545
> TEST=media_unittests
> 
> Committed: https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7
> Cr-Commit-Position: refs/heads/master@{#382417}

TBR=sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596641,595545
==========

to

==========
Revert of media: Stop flushing the renderer for pipeline suspend (patchset #2
id:20001 of https://codereview.chromium.org/1815423002/ )

Reason for revert:
This hit a CHECK in PipelineIntegrationTest.SuspendWhilePlaying

[12876:12876:0321/173811:1285613567:FATAL:ffmpeg_demuxer.cc(592)] Check failed:
read_cb_.is_null(). Overlapping reads are not supported

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28...

This was something we didn't consider and probably can't be relanded without a
fair amount of work.

Original issue's description:
> media: Stop flushing the renderer for pipeline suspend
> 
> Previously when performing a pipeline suspend we would flush the
> renderer before destructing it. This CL removes the flush because
> it's no longer necessary and has issues:
> 1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
>    a difference for fullscreen transitions), and
> 2) on <API level 18 devices it will cause AVDA to go into an
>    error state when it handles the flush by creating a new
>    MediaCodec without a valid output surface.
> 
> BUG=596641,595545
> TEST=media_unittests
> 
> Committed: https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7
> Cr-Commit-Position: refs/heads/master@{#382417}

TBR=sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596641,595545
==========

[commit-bot: I haz the power, 2016-03-22 00:57:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-22 00:59:02]

Description was changed from

==========
Revert of media: Stop flushing the renderer for pipeline suspend (patchset #2
id:20001 of https://codereview.chromium.org/1815423002/ )

Reason for revert:
This hit a CHECK in PipelineIntegrationTest.SuspendWhilePlaying

[12876:12876:0321/173811:1285613567:FATAL:ffmpeg_demuxer.cc(592)] Check failed:
read_cb_.is_null(). Overlapping reads are not supported

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28...

This was something we didn't consider and probably can't be relanded without a
fair amount of work.

Original issue's description:
> media: Stop flushing the renderer for pipeline suspend
> 
> Previously when performing a pipeline suspend we would flush the
> renderer before destructing it. This CL removes the flush because
> it's no longer necessary and has issues:
> 1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
>    a difference for fullscreen transitions), and
> 2) on <API level 18 devices it will cause AVDA to go into an
>    error state when it handles the flush by creating a new
>    MediaCodec without a valid output surface.
> 
> BUG=596641,595545
> TEST=media_unittests
> 
> Committed: https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7
> Cr-Commit-Position: refs/heads/master@{#382417}

TBR=sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596641,595545
==========

to

==========
Revert of media: Stop flushing the renderer for pipeline suspend (patchset #2
id:20001 of https://codereview.chromium.org/1815423002/ )

Reason for revert:
This hit a CHECK in PipelineIntegrationTest.SuspendWhilePlaying

[12876:12876:0321/173811:1285613567:FATAL:ffmpeg_demuxer.cc(592)] Check failed:
read_cb_.is_null(). Overlapping reads are not supported

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28...

This was something we didn't consider and probably can't be relanded without a
fair amount of work.

Original issue's description:
> media: Stop flushing the renderer for pipeline suspend
>
> Previously when performing a pipeline suspend we would flush the
> renderer before destructing it. This CL removes the flush because
> it's no longer necessary and has issues:
> 1) it adds ~100-150ms to suspend on a Galaxy Nexus (which makes
>    a difference for fullscreen transitions), and
> 2) on <API level 18 devices it will cause AVDA to go into an
>    error state when it handles the flush by creating a new
>    MediaCodec without a valid output surface.
>
> BUG=596641,595545
> TEST=media_unittests
>
> Committed: https://crrev.com/9edddb9ded49023460a204675ee4e9bb763b9da7
> Cr-Commit-Position: refs/heads/master@{#382417}

TBR=sandersd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596641,595545

Committed: https://crrev.com/4c88276f8f1fdcb0a921bfb979e22cd2acf241bb
Cr-Commit-Position: refs/heads/master@{#382465}
==========

[commit-bot: I haz the power, 2016-03-22 00:59:03]

Patchset 1 (id:??) landed as
https://crrev.com/4c88276f8f1fdcb0a921bfb979e22cd2acf241bb
Cr-Commit-Position: refs/heads/master@{#382465}

[sandersd (OOO until July 31), 2016-03-22 01:01:32]

lgtm