Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1824903002: Change the AlternativeServiceMap with SchemeOriginPair key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 67fe38c5458529de58356a15e206fd93af4bffef..afd4191cc94e9ec179210be3b4dce639c8c0ffbb 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -889,8 +889,10 @@ TEST_P(HttpStreamFactoryTest, UsePreConnectIfNoZeroRTT) {
alternative_service_info_vector.push_back(
AlternativeServiceInfo(alternative_service, 1.0, expiration));
HostPortPair host_port_pair(alternative_service.host_port_pair());
+ SchemeOriginPair scheme_origin_pair("https", host_port_pair);
+
http_server_properties.SetAlternativeServices(
- host_port_pair, alternative_service_info_vector);
+ scheme_origin_pair, alternative_service_info_vector);
SpdySessionDependencies session_deps(
GetParam(), ProxyService::CreateFixed("http_proxy"));
@@ -933,8 +935,10 @@ TEST_P(HttpStreamFactoryTest, QuicDisablePreConnectIfZeroRtt) {
alternative_service_info_vector.push_back(
AlternativeServiceInfo(alternative_service, 1.0, expiration));
HostPortPair host_port_pair(alternative_service.host_port_pair());
+ SchemeOriginPair scheme_origin_pair("https", host_port_pair);
+
http_server_properties.SetAlternativeServices(
- host_port_pair, alternative_service_info_vector);
+ scheme_origin_pair, alternative_service_info_vector);
SpdySessionDependencies session_deps(GetParam());
@@ -1566,8 +1570,9 @@ class HttpStreamFactoryBidirectionalQuicTest
alternative_service_info_vector.push_back(
AlternativeServiceInfo(alternative_service, 1.0, expiration));
HostPortPair host_port_pair(alternative_service.host_port_pair());
+ SchemeOriginPair scheme_origin_pair("https", host_port_pair);
http_server_properties_.SetAlternativeServices(
- host_port_pair, alternative_service_info_vector);
+ scheme_origin_pair, alternative_service_info_vector);
};
test::QuicTestPacketMaker& packet_maker() { return packet_maker_; }
@@ -1887,7 +1892,8 @@ TEST_P(HttpStreamFactoryTest, DISABLED_OrphanedWebSocketStream) {
base::Time expiration = base::Time::Now() + base::TimeDelta::FromDays(1);
session->http_server_properties()->SetAlternativeService(
- HostPortPair("www.google.com", 8888),
+ SchemeOriginPair(request_info.url.scheme(),
+ HostPortPair("www.google.com", 8888)),
AlternativeService(NPN_HTTP_2, "www.google.com", 9999), 1.0, expiration);
SSLConfig ssl_config;

Powered by Google App Engine
This is Rietveld 408576698