runtime/vm/profiler.cc - Issue 1824883002: Don't take a stack trace if we are in the middle of a deoptimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.cc

Issue 1824883002: Don't take a stack trace if we are in the middle of a deoptimization (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler.cc

diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc

index 1b589d91a2c924f9a386d2a587a294ca09ad9e36..6378c449338debe838b36f14f71e895b284608c0 100644

--- a/runtime/vm/profiler.cc

+++ b/runtime/vm/profiler.cc

@@ -989,6 +989,10 @@ void Profiler::SampleThread(Thread* thread,

return;

}

+ if (thread->IsMutatorThread() && isolate->IsDeoptimizing()) {

+ return;

+ }

uword stack_lower = 0;

uword stack_upper = 0;

if (!GetAndValidateIsolateStackBounds(thread,

« no previous file with comments | « runtime/vm/isolate.h ('k') | no next file » | no next file with comments »