Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1824813002: Resize of blimpview on text input (Closed)

Created:
4 years, 9 months ago by shaktisahu
Modified:
4 years, 9 months ago
Reviewers:
nyquist, Khushal, haibinlu
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resize of blimpview on text input This is a temporary fix to prevent resize of blimp view and at the same time be able to show the WebInputBox right above IME to enable the user to see what they type. Without resize, WebInputBox hides under IME. Current fix is to resize the view only when text input is required and resize it back after hiding IME. BUG=596653 Committed: https://crrev.com/68de803474c115c96b034175b7e6f4db7bc25dff Cr-Commit-Position: refs/heads/master@{#383178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M blimp/client/app/android/java/src/org/chromium/blimp/input/WebInputBox.java View 5 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
shaktisahu
nyquist@chromium.org: Please review changes in
4 years, 9 months ago (2016-03-22 19:45:52 UTC) #2
shaktisahu
4 years, 9 months ago (2016-03-24 21:07:43 UTC) #5
haibinlu
What is the CC communication cost between Engine and Client when this resizing is used?
4 years, 9 months ago (2016-03-24 21:18:13 UTC) #6
haibinlu
lgtm
4 years, 9 months ago (2016-03-24 21:29:03 UTC) #7
Khushal
lgtm. Thanks!
4 years, 9 months ago (2016-03-24 22:12:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824813002/1
4 years, 9 months ago (2016-03-24 22:20:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 23:05:22 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:07:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68de803474c115c96b034175b7e6f4db7bc25dff
Cr-Commit-Position: refs/heads/master@{#383178}

Powered by Google App Engine
This is Rietveld 408576698