Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: ui/file_manager/video_player/js/video_player.js

Issue 1824803003: VideoPlayer: Create subtitles button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add closure compiler annotation Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/video_player/js/video_player.js
diff --git a/ui/file_manager/video_player/js/video_player.js b/ui/file_manager/video_player/js/video_player.js
index 469e09e95bf60a51ed0fceec37301a04c7391792..4b9837698ec249a23c7382c277692e62bcd13da3 100644
--- a/ui/file_manager/video_player/js/video_player.js
+++ b/ui/file_manager/video_player/js/video_player.js
@@ -366,7 +366,6 @@ VideoPlayer.prototype.loadVideo_ = function(video, opt_callback) {
this.currentSession_ = session;
this.videoElement_ = new CastVideoElement(media, session);
- this.controls.attachMedia(this.videoElement_);
}.bind(this));
}.bind(this));
} else {
@@ -377,7 +376,6 @@ VideoPlayer.prototype.loadVideo_ = function(video, opt_callback) {
getRequiredElement('video-container').appendChild(this.videoElement_);
var videoUrl = video.toURL();
- this.controls.attachMedia(this.videoElement_);
var source = document.createElement('source');
source.src = videoUrl;
this.videoElement_.appendChild(source);
@@ -424,6 +422,7 @@ VideoPlayer.prototype.loadVideo_ = function(video, opt_callback) {
chrome.power.releaseKeepAwake();
this.updateInactivityWatcherState_();
}.wrap(this));
+ this.controls.attachMedia(this.videoElement_);
// TODO(ryoh):
// If you modify the video element that is already inserted,
// you have to call load() method.

Powered by Google App Engine
This is Rietveld 408576698