VideoPlayer: Create subtitles button.

VideoPlayer: Create subtitles button.

In this CL, I created "subtitles" button next to the fullscreen button.
This button is enabled/disabled when the media attached.

BUG=585723
TEST=manually

Committed: https://crrev.com/be1fc0e77549a67f28538a8464b31990c1832651
Cr-Commit-Position: refs/heads/master@{#383473}

[ryoh, 2016-03-22 08:58:05]

ryoh@chromium.org changed reviewers:
+ yoshiki@chromium.org

[ryoh, 2016-03-22 08:58:06]

Hi, I created subtitles button in VideoPlayer.
Could you take a look?

[ryoh, 2016-03-25 13:01:36]

Please let me ping you again.
Could you take a look?

[yoshiki, 2016-03-25 13:18:41]

sorry for late. lgtm with nit

https://codereview.chromium.org/1824803003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/media_controls.js (right):

https://codereview.chromium.org/1824803003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/media_controls.js:624: }else{
nit: spaces before and after "else".

[ryoh, 2016-03-28 00:27:14]

Thanks!

https://codereview.chromium.org/1824803003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/media_controls.js (right):

https://codereview.chromium.org/1824803003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/media_controls.js:624: }else{
On 2016/03/25 13:18:41, yoshiki wrote:
> nit: spaces before and after "else".

Done.

[ryoh, 2016-03-28 00:27:25]

The CQ bit was checked by ryoh@chromium.org

[ryoh, 2016-03-28 00:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/1824803003/#ps40001
(title: "fix nits")

[commit-bot: I haz the power, 2016-03-28 00:27:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824803003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824803003/40001

[commit-bot: I haz the power, 2016-03-28 00:59:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-28 01:01:07]

Description was changed from

==========
VideoPlayer: Create subtitles button.

In this CL, I created "subtitles" button next to the fullscreen button.
This button is enabled/disabled when the media attached.

BUG=585723
TEST=manually
==========

to

==========
VideoPlayer: Create subtitles button.

In this CL, I created "subtitles" button next to the fullscreen button.
This button is enabled/disabled when the media attached.

BUG=585723
TEST=manually

Committed: https://crrev.com/be1fc0e77549a67f28538a8464b31990c1832651
Cr-Commit-Position: refs/heads/master@{#383473}
==========

[commit-bot: I haz the power, 2016-03-28 01:01:08]

Patchset 3 (id:??) landed as
https://crrev.com/be1fc0e77549a67f28538a8464b31990c1832651
Cr-Commit-Position: refs/heads/master@{#383473}