Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1824753002: Plumb trial association without overriding a feature to subprocesses. (Closed)

Created:
4 years, 9 months ago by Alexei Svitkine (slow)
Modified:
4 years, 9 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb trial association without overriding a feature to subprocesses. This makes features used in only in renders report their default group correctly as well. This is done by having the --enable-features flag also plumb the non-overriding associations over. This way, when a feature is queried in the renderer, the associated trial is activated there (and then synced to the browser). BUG=587135 Committed: https://crrev.com/6d31c52edc9c6d20419b6fe12f66c60548ab7142 Cr-Commit-Position: refs/heads/master@{#382575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
M base/feature_list.h View 2 chunks +8 lines, -4 lines 0 comments Download
M base/feature_list.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M base/feature_list_unittest.cc View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Alexei Svitkine (slow)
4 years, 9 months ago (2016-03-21 19:19:50 UTC) #3
rkaplow
lgtm
4 years, 9 months ago (2016-03-22 15:06:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824753002/20001
4 years, 9 months ago (2016-03-22 15:07:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-22 15:38:00 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 15:39:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d31c52edc9c6d20419b6fe12f66c60548ab7142
Cr-Commit-Position: refs/heads/master@{#382575}

Powered by Google App Engine
This is Rietveld 408576698