Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None

Committed: https://crrev.com/7cf59c2689f31a12f04cd0bf1a9ba6c69adc6066
Cr-Commit-Position: refs/heads/master@{#405756}

[Thiemo Nagel, 2016-03-21 18:32:25]

tnagel@chromium.org changed reviewers:
+ cschuet@chromium.org

[Thiemo Nagel, 2016-03-21 18:32:26]

Hi Christoph,

as discussed, could you please take a look?

Thank you!
Thiemo

[cschuet (SLOW), 2016-03-21 22:43:46]

On 2016/03/21 18:32:26, Thiemo Nagel wrote:
> Hi Christoph,
> 
> as discussed, could you please take a look?
> 
> Thank you!
> Thiemo

Can you add a test for this to prevent regressions?

[Thiemo Nagel, 2016-03-22 11:32:29]

Patchset #2 (id:20001) has been deleted

[Thiemo Nagel, 2016-03-22 11:35:31]

I've better separated concerns now (and added a test).  Could you please take
another look?

Thank you!
Thiemo

[cschuet (SLOW), 2016-03-22 11:39:07]

On 2016/03/22 11:35:31, Thiemo Nagel wrote:
> I've better separated concerns now (and added a test).  Could you please take
> another look?
> 
> Thank you!
> Thiemo

lgtm

[Thiemo Nagel, 2016-03-22 12:00:23]

> lgtm

Many thanks!

[Thiemo Nagel, 2016-03-22 12:00:27]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-03-22 12:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from cschuet@chromium.org
Link to the patchset: https://codereview.chromium.org/1824743002/#ps60001
(title: "Fix line-wrap.")

[commit-bot: I haz the power, 2016-03-22 12:00:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824743002/60001

[commit-bot: I haz the power, 2016-03-22 12:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 12:28:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Thiemo Nagel, 2016-03-24 23:36:09]

Description was changed from

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

BUG=None
==========

to

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None
==========

[Thiemo Nagel, 2016-03-24 23:37:19]

That escalated quickly... initially I thought this was a 20-line change.

Could you please take another look?

Thank you!
Thiemo

[Thiemo Nagel, 2016-06-02 13:25:53]

Hi Christoph,

could you please take another look?

Thank you,
Thiemo

[Thiemo Nagel, 2016-07-01 14:00:43]

Ping! Ping! Ping!

[cschuet (SLOW), 2016-07-04 06:57:05]

On 2016/07/01 14:00:43, Thiemo Nagel wrote:
> Ping! Ping! Ping!

lgtm

[Thiemo Nagel, 2016-07-15 13:40:29]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2016-07-15 13:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from cschuet@chromium.org
Link to the patchset: https://codereview.chromium.org/1824743002/#ps280001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-15 13:40:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 14:50:37]

Description was changed from

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None
==========

to

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None
==========

[commit-bot: I haz the power, 2016-07-15 14:50:38]

Committed patchset #14 (id:280001)

[commit-bot: I haz the power, 2016-07-15 14:52:15]

Description was changed from

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None
==========

to

==========
Drop non-user policy in ConfigDirPolicyLoader on Chrome OS.

Device Policy that is read through ConfigDirPolicyLoader is ignored
yet it is still displayed on chrome://policy which is confusing. This
CL changes ConfigDirPolicyLoader to drop such policy already during
reading.  (To be consistent, unknown policies loaded through
ConfigDirPolicyLoader are dropped as well.)

Some refactoring was required to fulfill the (now) conflicting
requirements of ConfigurationPolicyProviderTest for different
platforms.

BUG=None

Committed: https://crrev.com/7cf59c2689f31a12f04cd0bf1a9ba6c69adc6066
Cr-Commit-Position: refs/heads/master@{#405756}
==========

[commit-bot: I haz the power, 2016-07-15 14:52:16]

Patchset 14 (id:??) landed as
https://crrev.com/7cf59c2689f31a12f04cd0bf1a9ba6c69adc6066
Cr-Commit-Position: refs/heads/master@{#405756}