src/core/SkScan.h - Issue 1824733002: For *ToFixed, in debug mode, assert that the value is in range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkScan.h

Issue 1824733002: For *ToFixed, in debug mode, assert that the value is in range. (Closed) Base URL: https://skia.googlesource.com/skia@scalar-pin-to-fixed

Patch Set: Get rid of #undef. Don't #ifdef SK_DEBUG. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkScan.h

diff --git a/src/core/SkScan.h b/src/core/SkScan.h

index 7309a1dd8c3ae3c67ebefa065ef072022d474427..2ae10f614bb65c8345cb96b9134434c1c372fa8b 100644

--- a/src/core/SkScan.h

+++ b/src/core/SkScan.h

@@ -93,7 +93,7 @@ static inline void XRect_set(SkXRect* xr, const SkIRect& src) {

}

/** Assign an SkXRect from a SkRect, by promoting the src rect's coordinates

- from SkScalar to SkFixed. Does not check for overflow if the src coordinates

+ from SkScalar to SkFixed. Behavior is undefined if the src coordinates

exceed 32K

static inline void XRect_set(SkXRect* xr, const SkRect& src) {

« include/core/SkFixed.h ('K') | « include/core/SkFixed.h ('k') | src/effects/gradients/SkTwoPointConicalGradient.cpp » ('j') | no next file with comments »