[chromecast] Pass media task runner to VideoPlaneController.

[chromecast] Pass media task runner to VideoPlaneController.

This required making VideoPlaneController non-singleton and
passed around wherever required, which is also a good change.

BUG=594234
Committed: https://crrev.com/ff847a1068a3e5872d091af9c673bc715771fa5d
Cr-Commit-Position: refs/heads/master@{#382877}

[alokp, 2016-03-22 11:23:26]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2016-03-23 13:12:17]

lgtm, just one question.

https://codereview.chromium.org/1824723003/diff/20001/chromecast/browser/cast...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/1824723003/diff/20001/chromecast/browser/cast...
chromecast/browser/cast_browser_main_parts.cc:471:
base::Bind(&media::CastMediaShlib::Finalize));
PostDestroyThreads is commented as "after threads have been stopped and
destroyed", so it looks odd to be posting work to a thread at this point.  Does
PostDestroyThreads comment only apply to certain specific threads (like IO) and
not our media thread?  Are you intending once all this refactoring is done to
try setting our media thread task runner to a different thread (e.g. same as
audio)?

[alokp, 2016-03-23 16:19:33]

https://codereview.chromium.org/1824723003/diff/20001/chromecast/browser/cast...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/1824723003/diff/20001/chromecast/browser/cast...
chromecast/browser/cast_browser_main_parts.cc:471:
base::Bind(&media::CastMediaShlib::Finalize));
On 2016/03/23 13:12:17, halliwell wrote:
> PostDestroyThreads is commented as "after threads have been stopped and
> destroyed", so it looks odd to be posting work to a thread at this point. 
Does
> PostDestroyThreads comment only apply to certain specific threads (like IO)
and
> not our media thread?  Are you intending once all this refactoring is done to
> try setting our media thread task runner to a different thread (e.g. same as
> audio)?

Yes it only applies to threads managed by BrowserMainLoop. As of this patch we
manage our own media thread so it is OK for now. This media thread will change
with the work I am doing on AudioManager, but we should still let
CastBrowserMainParts to Finalize the media shlib.

[alokp, 2016-03-23 16:35:23]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-23 16:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1824723003/#ps40001
(title: "fixed gn check")

[commit-bot: I haz the power, 2016-03-23 16:35:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824723003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824723003/40001

[commit-bot: I haz the power, 2016-03-23 17:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 17:11:39]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[alokp, 2016-03-23 17:17:36]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-23 17:17:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1824723003/#ps60001
(title: "fixed android build")

[commit-bot: I haz the power, 2016-03-23 17:17:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824723003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824723003/60001

[commit-bot: I haz the power, 2016-03-23 17:57:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-23 17:58:49]

Description was changed from

==========
[chromecast] Pass media task runner to VideoPlaneController.

This required making VideoPlaneController non-singleton and
passed around wherever required, which is also a good change.

BUG=594234
==========

to

==========
[chromecast] Pass media task runner to VideoPlaneController.

This required making VideoPlaneController non-singleton and
passed around wherever required, which is also a good change.

BUG=594234

Committed: https://crrev.com/ff847a1068a3e5872d091af9c673bc715771fa5d
Cr-Commit-Position: refs/heads/master@{#382877}
==========

[commit-bot: I haz the power, 2016-03-23 17:58:50]

Patchset 4 (id:??) landed as
https://crrev.com/ff847a1068a3e5872d091af9c673bc715771fa5d
Cr-Commit-Position: refs/heads/master@{#382877}