Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1824723002: Subzero: Add presubmit-lite target. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add presubmit-lite target. The big reduction is in greatly reducing the set of non-native cross tests. Also, not so many copies of spec2k are run, and only one "representative" sandboxed target is built. BUG= none R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e13d1ebb61b0ae97e0f432769803c660157b3545

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M Makefile.standalone View 4 chunks +65 lines, -2 lines 3 comments Download

Messages

Total messages: 8 (3 generated)
Jim Stichnoth
Motivated by trying to develop on a laptop over the weekend...
4 years, 9 months ago (2016-03-21 18:19:25 UTC) #3
Eric Holk
https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone#newcode357 Makefile.standalone:357: NEXES_LITE = $(SB_OBJDIR)/pnacl-sz.x8664.nexe Does this bake in the assumption ...
4 years, 9 months ago (2016-03-21 18:26:39 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone#newcode357 Makefile.standalone:357: NEXES_LITE = $(SB_OBJDIR)/pnacl-sz.x8664.nexe On 2016/03/21 18:26:38, Eric Holk wrote: ...
4 years, 9 months ago (2016-03-21 18:59:33 UTC) #5
Eric Holk
lgtm https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1824723002/diff/1/Makefile.standalone#newcode357 Makefile.standalone:357: NEXES_LITE = $(SB_OBJDIR)/pnacl-sz.x8664.nexe On 2016/03/21 18:59:33, stichnot wrote: ...
4 years, 9 months ago (2016-03-21 19:20:49 UTC) #6
Jim Stichnoth
4 years, 9 months ago (2016-03-21 19:49:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e13d1ebb61b0ae97e0f432769803c660157b3545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698