Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: ui/message_center/views/message_view.cc

Issue 18247002: Remove the most obvious dead code from message center. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move MessageCenterButtonBar into cc file to hide implementation. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_simple_view.cc ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/message_view.cc
diff --git a/ui/message_center/views/message_view.cc b/ui/message_center/views/message_view.cc
index 18f146cdbda51e459b4510550fa8c342a770ed05..cf1bbeaba4aae23854bff6a6195fd0eae153befa 100644
--- a/ui/message_center/views/message_view.cc
+++ b/ui/message_center/views/message_view.cc
@@ -247,10 +247,8 @@ MenuModel::MenuModel(message_center::MessageCenter* message_center,
display_source));
}
// Add settings menu item.
- if (message_center::IsRichNotificationEnabled() || !display_source.empty()) {
- AddItem(kShowSettingsCommand,
- l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_SETTINGS));
- }
+ AddItem(kShowSettingsCommand,
+ l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_SETTINGS));
}
MenuModel::~MenuModel() {
@@ -283,7 +281,7 @@ void MenuModel::ExecuteCommand(int command_id, int event_flags) {
break;
case kShowSettingsCommand:
// |tray_| may be NULL in tests.
- if (message_center::IsRichNotificationEnabled() && tray_)
+ if (tray_)
tray_->ShowNotifierSettingsBubble();
else
message_center_->ShowNotificationSettings(notification_id_);
« no previous file with comments | « ui/message_center/views/message_simple_view.cc ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698