Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: ui/message_center/message_center_tray.cc

Issue 18247002: Remove the most obvious dead code from message center. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move MessageCenterButtonBar into cc file to hide implementation. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/message_center.gyp ('k') | ui/message_center/message_center_tray_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center_tray.cc
diff --git a/ui/message_center/message_center_tray.cc b/ui/message_center/message_center_tray.cc
index 7f74a1eea2c282eb4ce141fecc7e65cfd69c3017..46438cc9d6c8e7f56b1e62aa08fceed8bda7afb4 100644
--- a/ui/message_center/message_center_tray.cc
+++ b/ui/message_center/message_center_tray.cc
@@ -72,7 +72,6 @@ void MessageCenterTray::ShowPopupBubble() {
return;
if (popups_visible_) {
- delegate_->UpdatePopups();
NotifyMessageCenterTrayChanged();
return;
}
@@ -153,14 +152,11 @@ void MessageCenterTray::OnMessageCenterChanged() {
if (message_center_->NotificationCount() == 0)
HideMessageCenterBubble();
}
- if (popups_visible_) {
- if (message_center_->HasPopupNotifications())
- delegate_->UpdatePopups();
- else
- HidePopupBubble();
- } else if (message_center_->HasPopupNotifications()) {
+
+ if (popups_visible_ && !message_center_->HasPopupNotifications())
+ HidePopupBubble();
+ else if (message_center_->HasPopupNotifications())
ShowPopupBubble();
- }
NotifyMessageCenterTrayChanged();
}
« no previous file with comments | « ui/message_center/message_center.gyp ('k') | ui/message_center/message_center_tray_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698