Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1824693003: Make GrCircleBlurFragmentProcessor::onIsEqual include the position (Closed)

Created:
4 years, 9 months ago by abarth-chromium
Modified:
4 years, 9 months ago
Reviewers:
abarth, robertphillips
CC:
reviews_skia.org, joshualitt
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrCircleBlurFragmentProcessor::onIsEqual include the position Previously we would fail to draw two adjacent blurred circles if they differed only by their position. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824693003 Committed: https://skia.googlesource.com/skia/+/ddf0713f0ba4ea75ca49a4ed6b4249eef72da1ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/GrCircleBlurFragmentProcessor.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
abarth
Hey, circles had the same bug as RRects. (See https://bugs.chromium.org/p/skia/issues/detail?id=5014 and https://codereview.chromium.org/1743553003.) Here's some Flutter ...
4 years, 9 months ago (2016-03-21 22:21:12 UTC) #3
robertphillips
lgtm
4 years, 9 months ago (2016-03-22 13:05:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824693003/1
4 years, 9 months ago (2016-03-22 13:06:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 14:16:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824693003/1
4 years, 9 months ago (2016-03-22 16:13:46 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:14:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ddf0713f0ba4ea75ca49a4ed6b4249eef72da1ce

Powered by Google App Engine
This is Rietveld 408576698