Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

Issue 1824683002: Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mouse… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mouse… Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html b/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
index 5d9ef3f4f617a0fe158714f9433b41dbbc1a102b..f2e91a86fadc9ad3cfe4654ad592afd1e784ee55 100644
--- a/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
@@ -26,11 +26,14 @@ function test()
var colorTreeElement = InspectorTest.getMatchedStylePropertyTreeItem("color");
colorTreeElement.startEditing(colorTreeElement.valueElement);
- // Most significant digit increment ('F') should not change the value.
- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp", false, false, true));
- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up"));
- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageDown"));
- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageDown", false, false, true));
+ // PageUp should change to 'FF3'
+ colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp"));
+ // Ctrl/Meta + Shift Down should change to 'EE3'
+ if (WebInspector.isMac())
+ colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Down", /*Ctrl*/ false, /*Alt*/ false, /*Shift*/ true, /*Meta*/ true));
+ else
+ colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Down", /*Ctrl*/ true, /*Alt*/ false, /*Shift*/ true, /*Meta*/ false));
+
InspectorTest.addResult(colorTreeElement.listItemElement.textContent);
next();
},
@@ -39,13 +42,12 @@ function test()
{
var opacityTreeElement = InspectorTest.getMatchedStylePropertyTreeItem("opacity");
opacityTreeElement.startEditing(opacityTreeElement.valueElement);
- // 0.5 (initial)
- opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up", false, true, false)); // Alt-Up
- // 0.6
+ // 0.5 (initial). Alt + Up should change to 0.6
+ opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up", /*Ctrl*/ false, /*Alt*/ true, /*Shift*/ false));
+ // Up should change to 1.6
opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up"));
- // 1.6
- opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp"));
- // 11.6
+ // Shift + PageUp should change to 11.6
+ opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp", /*Ctrl*/ false, /*Alt*/ false, /*Shift*/ true));
InspectorTest.addResult(opacityTreeElement.listItemElement.textContent);
next();
},
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698