Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mouse…

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 171 matching lines @@
             this._element.removeChildren();
             this._element.createChild("br");
         } else {
             this._element.textContent = x;
         }
 
         this.moveCaretToEndOfPrompt();
         this._element.scrollIntoView();
     },
 
+    /**
+     * @return {string}
+     */
+    title: function()
+    {
+        return this._element.title;

[lushnikov, 2016/03/25 18:48:32]

In order to make methods title() and setTitle() independent of prompt attachment
(indeed, why should they depend on that?), let's add a private member
this._title and return it here

+    },
+
+    /**
+     * @param {string} title
+     */
+    setTitle: function(title)
+    {
+        this._element.title = title;

[lushnikov, 2016/03/25 18:48:32]

I think it would be better to use this._proxyElement instead of this._element:
the this._element comes from the outside, whereas the proxyElement is under our
full control.

This method will translate into something like this:

this._title = title;
if (this._proxyElement)
   this._proxyElement = ...


Note: you might also need to update the proxyElements' title at the moment of
its creation in the
_attachInternal.

+    },
+
     _removeFromElement: function()
     {
         this.clearAutoComplete(true);
         this._element.removeEventListener("keydown", this._boundOnKeyDown, false);
         this._element.removeEventListener("input", this._boundOnInput, false);
         this._element.removeEventListener("selectstart", this._boundSelectStart, false);
         this._element.removeEventListener("blur", this._boundRemoveSuggestionAids, false);
         this._element.ownerDocument.defaultView.removeEventListener("resize", this._boundRemoveSuggestionAids, false);
         if (this._isEditing)
             this._stopEditing();
         if (this._suggestBox)
             this._suggestBox.removeFromElement();
     },
 
+    onEditStart: function()
+    {
+        // Subclasses can implement.
+    },
+
+    onEditDone: function()
+    {
+        // Subclasses can implement.
+    },
+
     /**
      * @param {function(!Event)=} blurListener
      */
     _startEditing: function(blurListener)
     {
         this._isEditing = true;
         this._contentElement.classList.add("text-prompt-editing");
         if (blurListener) {
             this._blurListener = blurListener;
             this._element.addEventListener("blur", this._blurListener, false);
         }
         this._oldTabIndex = this._element.tabIndex;
         if (this._element.tabIndex < 0)
             this._element.tabIndex = 0;
         WebInspector.setCurrentFocusElement(this._element);
         if (!this.text())
             this._updateAutoComplete();
+        this.onEditStart();
     },
 
     _stopEditing: function()
     {
         this._element.tabIndex = this._oldTabIndex;
         if (this._blurListener)
             this._element.removeEventListener("blur", this._blurListener, false);
         this._contentElement.classList.remove("text-prompt-editing");
         delete this._isEditing;
+        this.onEditDone();
     },
 
     _removeSuggestionAids: function()
     {
         this.clearAutoComplete();
         this.hideSuggestBox();
     },
 
     _selectStart: function()
     {
@@ skipping 726 matching lines @@
 
             return;
         }
 
         WebInspector.TextPrompt.prototype.onKeyDown.apply(this, arguments);
     },
 
     __proto__: WebInspector.TextPrompt.prototype
 }