Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mouse…

third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 2896 matching lines @@
          * @this {WebInspector.StylesSidebarPane.CSSPropertyPrompt}
          */
         function customNumberHandler(prefix, number, suffix)
         {
             if (number !== 0 && !suffix.length && WebInspector.CSSMetadata.isLengthProperty(this._treeElement.property.name))
                 suffix = "px";
             return prefix + number + suffix;
         }
 
         // Handle numeric value increment/decrement only at this point.
-        if (!this._isEditingName && WebInspector.handleElementValueModifications(event, this._treeElement.valueElement, finishHandler.bind(this), this._isValueSuggestion.bind(this), customNumberHandler.bind(this)))
+        if (!this._isEditingName && WebInspector.handleElementValueModifications(event, this._treeElement.valueElement, finishHandler.bind(this), this._isValueSuggestion.bind(this), customNumberHandler.bind(this))){

[lushnikov, 2016/03/22 17:21:42]

style: space before "{"

[nojvek, 2016/03/24 16:28:38]

Done.

+            if(!this._element.title)

[lushnikov, 2016/03/22 17:21:42]

why do we setup title so late? we should probably do it on editing start.

also, this._element is a private member of TextPrompt; let's create a
TextPrompt.setTitle public method instead of accessing private members here.

[nojvek, 2016/03/24 16:28:38]

Done.

+                this._element.title = WebInspector.UIString("Mousewheel or up/down keys. %s: ±100, Shift: ±10, Alt: ±0.1", WebInspector.isMac() ? "Cmd" : "Ctrl")
             return true;
+        }
 
         return false;
     },
 
     /**
      * @param {string} word
      * @return {boolean}
      */
     _isValueSuggestion: function(word)
     {
@@ skipping 155 matching lines @@
     WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, onNodeChanged);
     onNodeChanged();
     return button;
 
     function onNodeChanged()
     {
         var node = WebInspector.context.flavor(WebInspector.DOMNode);
         button.setEnabled(!!node);
     }
 }