Fixes 590477: Style pane numeric property change modifier shortcuts are undiscoverable. Shift mouse…

third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
@@ skipping 283 matching lines @@
 
 
 /**
  * @param {!Event} event
  * @return {?string}
  */
 WebInspector._valueModificationDirection = function(event)
 {
     var direction = null;
     if (event.type === "mousewheel") {
-        if (event.wheelDeltaY > 0)
+        // When shift is pressed while spinning mousewheel, delta comes as wheelDeltaX
+        if (event.wheelDeltaY > 0 || event.wheelDeltaX > 0)
             direction = "Up";
-        else if (event.wheelDeltaY < 0)
+        else if (event.wheelDeltaY < 0 || event.wheelDeltaX < 0)
             direction = "Down";
     } else {
         if (event.keyIdentifier === "Up" || event.keyIdentifier === "PageUp")
             direction = "Up";
         else if (event.keyIdentifier === "Down" || event.keyIdentifier === "PageDown")
             direction = "Down";
     }
     return direction;
 }
 
@@ skipping 39 matching lines @@
 /**
  * @param {number} number
  * @param {!Event} event
  */
 WebInspector._modifiedFloatNumber = function(number, event)
 {
     var direction = WebInspector._valueModificationDirection(event);
     if (!direction)
         return number;
 
-    var arrowKeyOrMouseWheelEvent = (event.keyIdentifier === "Up" || event.keyIdentifier === "Down" || event.type === "mousewheel");
-
-    // Jump by 10 when shift is down or jump by 0.1 when Alt/Option is down.
-    // Also jump by 10 for page up and down, or by 100 if shift is held with a page key.
+    // Precision modifier keys work with both mousewheel and up/down keys.
+    // When ctrl is pressed, increase by 100
+    // When shift is pressed, increase by 10
+    // When alt is pressed, increase by 0.1
+    // Otherwise increase by 1
     var changeAmount = 1;
-    if (event.shiftKey && !arrowKeyOrMouseWheelEvent)
+    if (event.ctrlKey)

[pfeldman, 2016/03/21 18:18:30]

WebInspector.KeyboardShortcut.eventHasCtrlOrMeta (to support Mac OS)

[nojvek, 2016/03/24 16:28:38]

Done.

         changeAmount = 100;
-    else if (event.shiftKey || !arrowKeyOrMouseWheelEvent)
-        changeAmount = 10;
     else if (event.altKey)
         changeAmount = 0.1;
+    else if (event.shiftKey)

[pfeldman, 2016/03/21 18:18:30]

Lets keep handlers in sorted order: 100, 10, 0.1

[nojvek, 2016/03/24 16:28:38]

Done.

+        changeAmount = 10;
 
     if (direction === "Down")
         changeAmount *= -1;
 
     // Make the new number and constrain it to a precision of 6, this matches numbers the engine returns.
     // Use the Number constructor to forget the fixed precision, so 1.100000 will print as 1.1.
     var result = Number((number + changeAmount).toFixed(6));
     if (!String(result).match(WebInspector.CSSNumberRegex))
         return null;
 
@@ skipping 1443 matching lines @@
             [NetworkAgent.ResourcePriority.High, WebInspector.UIString("High")],
             [NetworkAgent.ResourcePriority.VeryHigh, WebInspector.UIString("Highest")]
         ]);
         WebInspector.uiLabelForPriority._priorityToUILabel = labelMap;
     }
     return labelMap.get(priority) || WebInspector.UIString("Unknown");
 }
 
 /** @type {!WebInspector.ThemeSupport} */
 WebInspector.themeSupport;