Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1824613002: [regexp] require exact match for unicode property names. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] require exact match for unicode property names. R=littledan@chromium.org BUG=v8:4810 LOG=N Committed: https://crrev.com/5dedb164eb1ab797c467a8ca733a43da4c2b2179 Cr-Commit-Position: refs/heads/master@{#34961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -16 lines) Patch
M src/regexp/regexp-parser.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-blocks.js View 1 chunk +9 lines, -12 lines 0 comments Download
A test/mjsunit/harmony/regexp-property-exact-match.js View 1 chunk +33 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-general-category.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
4 years, 9 months ago (2016-03-21 14:14:54 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824613002/1
4 years, 9 months ago (2016-03-21 14:19:35 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15571)
4 years, 9 months ago (2016-03-21 16:43:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824613002/1
4 years, 9 months ago (2016-03-21 17:47:34 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 18:01:25 UTC) #9
Dan Ehrenberg
lgtm I like this version a lot; we can always go looser, but going stricter ...
4 years, 9 months ago (2016-03-21 18:44:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824613002/1
4 years, 9 months ago (2016-03-21 18:45:39 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 19:21:30 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:22:32 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5dedb164eb1ab797c467a8ca733a43da4c2b2179
Cr-Commit-Position: refs/heads/master@{#34961}

Powered by Google App Engine
This is Rietveld 408576698