Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1824533002: [json] Allow any callable object for toJSON. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] Allow any callable object for toJSON. Previously only JSFunctions seemed to be valid for toJSON, which doesn't match the ES6 specification that allows any object with [[Call]] internal method (i.e. any Callable in V8 terminology), including bound functions and proxies. BUG=chromium:595738, chromium:535408 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/cc04776632834726aefcf8914ef5fb1ebb745a93 Cr-Commit-Position: refs/heads/master@{#34913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-595738.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-20 18:53:12 UTC) #1
Benedikt Meurer
Hey Yang, Quickfix for toJSON checking in C++ land (the JS version was already fixed ...
4 years, 9 months ago (2016-03-20 18:55:40 UTC) #2
Yang
On 2016/03/20 18:53:12, Benedikt Meurer - OOO wrote: lgtm
4 years, 9 months ago (2016-03-20 18:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824533002/1
4 years, 9 months ago (2016-03-20 19:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-20 19:35:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 19:35:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc04776632834726aefcf8914ef5fb1ebb745a93
Cr-Commit-Position: refs/heads/master@{#34913}

Powered by Google App Engine
This is Rietveld 408576698