Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 182453004: Linux Sandbox: add Credentials::SupportsNewUserNS() (Closed)

Created:
6 years, 9 months ago by jln (very slow on Chromium)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, mdempsky
Visibility:
Public.

Description

Linux Sandbox: add Credentials::SupportsNewUserNS() We need to be able to check for unprivileged namespace support without actually unsharing the current namespace. We add a method that creates a new process with a new user namespace and see if this succeeds. BUG=312380 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254433

Patch Set 1 : #

Patch Set 2 : Make test pass on Valgrind. #

Total comments: 3

Patch Set 3 : Save errno. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M sandbox/linux/services/credentials.h View 1 chunk +7 lines, -0 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 1 2 4 chunks +51 lines, -5 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jln (very slow on Chromium)
Jorge, do you mind taking a look?
6 years, 9 months ago (2014-02-28 21:27:09 UTC) #1
mdempsky
https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc File sandbox/linux/services/credentials.cc (right): https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc#newcode295 sandbox/linux/services/credentials.cc:295: CheckCloneNewUserErrno(); Is the VLOG line guaranteed to not clobber ...
6 years, 9 months ago (2014-02-28 22:44:59 UTC) #2
Jorge Lucangeli Obes
lgtm % Matthew's comment. https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc File sandbox/linux/services/credentials.cc (right): https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc#newcode30 sandbox/linux/services/credentials.cc:30: bool IsRunningOnValgrind() { return RUNNING_ON_VALGRIND; ...
6 years, 9 months ago (2014-02-28 22:59:58 UTC) #3
jln (very slow on Chromium)
https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc File sandbox/linux/services/credentials.cc (right): https://codereview.chromium.org/182453004/diff/30001/sandbox/linux/services/credentials.cc#newcode295 sandbox/linux/services/credentials.cc:295: CheckCloneNewUserErrno(); On 2014/02/28 22:44:59, mdempsky_chromium wrote: > Is the ...
6 years, 9 months ago (2014-02-28 23:30:18 UTC) #4
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 9 months ago (2014-03-01 00:02:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/182453004/50001
6 years, 9 months ago (2014-03-01 00:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/182453004/50001
6 years, 9 months ago (2014-03-01 01:09:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/182453004/50001
6 years, 9 months ago (2014-03-01 01:30:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 01:36:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-01 01:36:35 UTC) #10
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 9 months ago (2014-03-03 06:17:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/182453004/50001
6 years, 9 months ago (2014-03-03 06:18:07 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 07:50:52 UTC) #13
Message was sent while issue was closed.
Change committed as 254433

Powered by Google App Engine
This is Rietveld 408576698