Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/public/platform/WebGraphicsContext3D.h

Issue 1824433002: Remove getError() and synthesizeGLError() from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simples-tplus
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebGraphicsContext3D.h
diff --git a/third_party/WebKit/public/platform/WebGraphicsContext3D.h b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
index dd9a6e3197b768f6014046c2b3b50af025e94a78..4ac32597039d6bc1f61081edcc305cb380e2a91d 100644
--- a/third_party/WebKit/public/platform/WebGraphicsContext3D.h
+++ b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
@@ -139,16 +139,6 @@ public:
virtual bool genSyncTokenCHROMIUM(WGC3Duint64, WGC3Dbyte*) { return false; }
- // Synthesizes an OpenGL error which will be returned from a
- // later call to getError. This is used to emulate OpenGL ES
- // 2.0 behavior on the desktop and to enforce additional error
- // checking mandated by WebGL.
- //
- // Per the behavior of glGetError, this stores at most one
- // instance of any given error, and returns them from calls to
- // getError in the order they were added.
- virtual void synthesizeGLError(WGC3Denum) = 0;
-
// GL_CHROMIUM_request_extension
virtual WebString getRequestableExtensionsCHROMIUM() = 0;
@@ -162,7 +152,6 @@ public:
virtual bool getActiveAttrib(WebGLId program, WGC3Duint index, ActiveInfo&) = 0;
virtual bool getActiveUniform(WebGLId program, WGC3Duint index, ActiveInfo&) = 0;
- virtual WGC3Denum getError() = 0;
virtual WebString getProgramInfoLog(WebGLId program) = 0;
virtual WebString getShaderInfoLog(WebGLId shader) = 0;
virtual WebString getShaderSource(WebGLId shader) = 0;

Powered by Google App Engine
This is Rietveld 408576698