third_party/WebKit/Source/modules/webgl/WebGLProgram.h - Issue 1824433002: Remove getError() and synthesizeGLError() from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLProgram.h

Issue 1824433002: Remove getError() and synthesizeGLError() from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simples-tplus

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLObject.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLProgram.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLProgram.h b/third_party/WebKit/Source/modules/webgl/WebGLProgram.h

index 960389a06b6b84d4d5dcb06e3c1e2ecce04eec8f..4be269a5934536780240a32e47674c34314ef223 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLProgram.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLProgram.h

@@ -40,11 +40,6 @@ public:

static WebGLProgram* create(WebGLRenderingContextBase*);

- unsigned numActiveAttribLocations();

- GLint getActiveAttribLocation(GLuint index);

- bool isUsingVertexAttrib0();

bool linkStatus();

unsigned linkCount() const { return m_linkCount; }

@@ -76,8 +71,6 @@ private:

void cacheActiveAttribLocations(WebGraphicsContext3D*, gpu::gles2::GLES2Interface*);

Ken Russell (switch to Gerrit) 2016/03/19 04:36:04 Should be deleted from header.

danakj 2016/03/21 22:45:13 Done.

void cacheInfoIfNeeded();

- Vector<GLint> m_activeAttribLocations;

GLint m_linkStatus;

// This is used to track whether a WebGLUniformLocation belongs to this