Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLContextGroup.h

Issue 1824433002: Remove getError() and synthesizeGLError() from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simples-tplus
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 public: 46 public:
47 static PassRefPtr<WebGLContextGroup> create(); 47 static PassRefPtr<WebGLContextGroup> create();
48 ~WebGLContextGroup(); 48 ~WebGLContextGroup();
49 49
50 void addContext(WebGLRenderingContextBase*); 50 void addContext(WebGLRenderingContextBase*);
51 void removeContext(WebGLRenderingContextBase*); 51 void removeContext(WebGLRenderingContextBase*);
52 52
53 void addObject(WebGLSharedObject*); 53 void addObject(WebGLSharedObject*);
54 void removeObject(WebGLSharedObject*); 54 void removeObject(WebGLSharedObject*);
55 55
56 // TODO(danakj): Make this getAWebGLRenderingContextBase.
56 WebGraphicsContext3D* getAWebGraphicsContext3D(); 57 WebGraphicsContext3D* getAWebGraphicsContext3D();
57 58
58 void loseContextGroup(WebGLRenderingContextBase::LostContextMode, WebGLRende ringContextBase::AutoRecoveryMethod); 59 void loseContextGroup(WebGLRenderingContextBase::LostContextMode, WebGLRende ringContextBase::AutoRecoveryMethod);
59 60
60 private: 61 private:
61 friend class WebGLObject; 62 friend class WebGLObject;
62 63
63 WebGLContextGroup(); 64 WebGLContextGroup();
64 65
65 void detachAndRemoveAllObjects(); 66 void detachAndRemoveAllObjects();
66 67
67 // FIXME: Oilpan: this object is not on the heap, but keeps untraced 68 // FIXME: Oilpan: this object is not on the heap, but keeps untraced
68 // pointers to on-heap objects in the two hash sets below. 69 // pointers to on-heap objects in the two hash sets below.
69 // The objects are responsible for managing their 70 // The objects are responsible for managing their
70 // registration with WebGLContextGroup, and vice versa, the 71 // registration with WebGLContextGroup, and vice versa, the
71 // WebGLContextGroup takes care of detaching the group objects if 72 // WebGLContextGroup takes care of detaching the group objects if
72 // the set of WebGLRenderingContextBase contexts becomes empty. 73 // the set of WebGLRenderingContextBase contexts becomes empty.
73 HashSet<RawPtrWillBeUntracedMember<WebGLRenderingContextBase>> m_contexts; 74 HashSet<RawPtrWillBeUntracedMember<WebGLRenderingContextBase>> m_contexts;
74 HashSet<UntracedMember<WebGLSharedObject>> m_groupObjects; 75 HashSet<UntracedMember<WebGLSharedObject>> m_groupObjects;
75 }; 76 };
76 77
77 } // namespace blink 78 } // namespace blink
78 79
79 #endif // WebGLContextGroup_h 80 #endif // WebGLContextGroup_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698