Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 182443004: [FastTextAutosizer] Do not inflate blocks with no children (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
Reviewers:
skobes
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

[FastTextAutosizer] Do not inflate blocks with no children This patch fixes a crash on empty documents where a cluster would not get created and we would crash during inflation. I've changed beginLayout to only call inflate when a block has children, and refactored endLayout similarly. BUG=348458 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
A LayoutTests/fast/text-autosizing/empty-document-crash.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/empty-document-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pdr.
6 years, 9 months ago (2014-03-03 21:23:37 UTC) #1
skobes
lgtm
6 years, 9 months ago (2014-03-03 21:27:33 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-03 21:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/182443004/1
6 years, 9 months ago (2014-03-03 21:30:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/182443004/1
6 years, 9 months ago (2014-03-03 23:21:54 UTC) #5
pdr.
On 2014/03/03 23:21:54, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-04 02:58:34 UTC) #6
pdr.
The CQ bit was unchecked by pdr@chromium.org
6 years, 9 months ago (2014-03-04 02:58:39 UTC) #7
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-04 02:58:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/182443004/1
6 years, 9 months ago (2014-03-04 02:58:56 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 03:09:43 UTC) #10
Message was sent while issue was closed.
Change committed as 168352

Powered by Google App Engine
This is Rietveld 408576698