Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: pkg/intl/lib/extract_messages.dart

Issue 182443003: Add 'meaning' to Intl.messages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/intl/lib/intl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/extract_messages.dart
diff --git a/pkg/intl/lib/extract_messages.dart b/pkg/intl/lib/extract_messages.dart
index 328b18de87e9ea4ea98d86b69d8fb11b6b3cdfa7..4464cf7904d3a5a6bfea4ae1de7ed84fb5b0edcf 100644
--- a/pkg/intl/lib/extract_messages.dart
+++ b/pkg/intl/lib/extract_messages.dart
@@ -280,7 +280,7 @@ class MessageFindingVisitor extends GeneralizingASTVisitor {
}
void setAttribute(MainMessage msg, String fieldName, String fieldValue) {
- if (["name", "desc", "examples", "args"].contains(fieldName)) {
+ if (msg.attributeNames.contains(fieldName)) {
msg[fieldName] = fieldValue;
}
}
@@ -413,6 +413,7 @@ class PluralAndGenderVisitor extends SimpleASTVisitor {
*/
String checkValidity(MethodInvocation node) {
// TODO(alanknight): Add reasonable validity checks.
+ return null;
}
/**
« no previous file with comments | « no previous file | pkg/intl/lib/intl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698