Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1824313002: [compiler] Unify printing of schedule block ids. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Unify printing of schedule block ids. We use the pattern "B23" to refer to RPO numbers and "id:42" when referring to unordered block ids. This unifies printing functions to follow that pattern throughout the system. R=danno@chromium.org Committed: https://crrev.com/ca387dbdaac1c7e3e16fdf9b5f3249b39d268d15 Cr-Commit-Position: refs/heads/master@{#35022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/schedule.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-23 09:24:17 UTC) #1
danno
lgtm
4 years, 9 months ago (2016-03-23 09:30:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824313002/1
4 years, 9 months ago (2016-03-23 09:53:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 09:55:55 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 09:57:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca387dbdaac1c7e3e16fdf9b5f3249b39d268d15
Cr-Commit-Position: refs/heads/master@{#35022}

Powered by Google App Engine
This is Rietveld 408576698