Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1824303002: check if we can split (linear scan) (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 8 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

check if we can split (linear scan) Revert "[wasm] Quickfix for register allocation problem on ia32." This reverts commit 2ca31b636bf03b67867ff94cc82fca84f48eb1d1. BUG= Committed: https://crrev.com/5ec339c4f04f76c2bf90e2deefc3250ba7e77682 Cr-Commit-Position: refs/heads/master@{#35559}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M src/compiler/register-allocator.h View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
titzer
lgtm https://codereview.chromium.org/1824303002/diff/60001/src/compiler/register-allocator.h File src/compiler/register-allocator.h (right): https://codereview.chromium.org/1824303002/diff/60001/src/compiler/register-allocator.h#newcode53 src/compiler/register-allocator.h:53: LifetimePosition next_gap = Clearer with an explicit if? ...
4 years, 8 months ago (2016-03-29 08:12:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824303002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824303002/100001
4 years, 8 months ago (2016-04-18 05:17:53 UTC) #6
Mircea Trofin
https://codereview.chromium.org/1824303002/diff/60001/src/compiler/register-allocator.h File src/compiler/register-allocator.h (right): https://codereview.chromium.org/1824303002/diff/60001/src/compiler/register-allocator.h#newcode53 src/compiler/register-allocator.h:53: LifetimePosition next_gap = On 2016/03/29 08:12:06, titzer wrote: > ...
4 years, 8 months ago (2016-04-18 05:18:37 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 8 months ago (2016-04-18 05:41:12 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 05:42:46 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5ec339c4f04f76c2bf90e2deefc3250ba7e77682
Cr-Commit-Position: refs/heads/master@{#35559}

Powered by Google App Engine
This is Rietveld 408576698