Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1824283002: Ensure that we don't allow 'normal' alongside other values in content property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
index 3e6d595f16a00cd870f3b561539feee56b9a7102..fc728a12bb13abe81c45f8eae8429ee9ac1bc389 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
@@ -657,6 +657,12 @@ void StyleBuilderFunctions::applyInheritCSSPropertyContent(StyleResolverState&)
void StyleBuilderFunctions::applyValueCSSPropertyContent(StyleResolverState& state, CSSValue* value)
{
+ if (value->isPrimitiveValue()) {
+ if (toCSSPrimitiveValue(*value).getValueID() == CSSValueNormal) {
Timothy Loh 2016/03/24 04:38:41 should be an assert instead since if we get here t
nainar 2016/03/29 00:56:39 Done.
+ state.style()->clearContent();
+ return;
+ }
+ }
// list of string, uri, counter, attr, i
bool didSet = false;

Powered by Google App Engine
This is Rietveld 408576698