third_party/WebKit/LayoutTests/css-parser/content-parsing.html - Issue 1824283002: Ensure that we don't allow 'normal' alongside other values in content property

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css-parser/content-parsing.html

Issue 1824283002: Ensure that we don't allow 'normal' alongside other values in content property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/css-parser/content-parsing-invalid.html » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="resources/property-parsing-test.js"></script>	4 <script src="resources/property-parsing-test.js"></script>

5 <script>	5 <script>

6 assert_valid_value("content", '"a"');	6 assert_valid_value("content", '"a"');

7 assert_valid_value("content", "open-quote");	7 assert_valid_value("content", "open-quote");

	8 assert_valid_value("content", "normal");

	9 assert_valid_value("content", 'url("test.html")');

	10

	11 assert_invalid_value("content", 'normal normal');

	12 assert_invalid_value("content", 'normal "a"');
	Timothy Loh 2016/03/24 04:38:41 should at least have one test case with normal as should at least have one test case with normal as the second value nainar 2016/03/29 00:56:39 Done. Done.
	13 assert_invalid_value("content", 'normal url("test.html")');

	14 assert_invalid_value("content", "normal 'open-quote;");
	Timothy Loh 2016/03/24 04:38:41 not sure what this case is trying to test with mis not sure what this case is trying to test with mismatched quotes??
8 assert_invalid_value("content", "not valid content");	15 assert_invalid_value("content", "not valid content");

9 assert_invalid_value("content", "open-quote invalid content");	16 assert_invalid_value("content", "open-quote invalid content");

10 assert_invalid_value("content", '"a" still not valid');	17 assert_invalid_value("content", '"a" still not valid');

11 assert_invalid_value("content", 'bla &@#$&^');	18 assert_invalid_value("content", 'bla &@#$&^');

12 assert_invalid_value("content", "'foo' *(&^");	19 assert_invalid_value("content", "'foo' *(&^");

13 assert_invalid_value("content", "open-quote 1+2+3=6");	20 assert_invalid_value("content", "open-quote 1+2+3=6");

14 </script>	21 </script>

OLD	NEW