Issue 1824253002: Remove the mojom-sources flag from dart_pkg.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1824253002: Remove the mojom-sources flag from dart_pkg.py (Closed)

Created:
4 years, 9 months ago by jsimmons1

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the mojom-sources flag from dart_pkg.py BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e0a020230e84629170ac939d2895bd5c1311cd91

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -82 lines)			Patch
M	mojo/public/dart/rules.gni	View	3 chunks	+5 lines, -23 lines	0 comments	Download
D	mojo/public/tools/dart_list_mojoms.py	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	mojo/public/tools/dart_pkg.py	View	3 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jsimmons1

4 years, 9 months ago (2016-03-23 20:13:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e0a020230e84629170ac939d2895bd5c1311cd91 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages