Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1824213002: Fix name resolution through re-exported libraries (Closed)

Created:
4 years, 9 months ago by hausner
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, dgrove, keertip
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix name resolution through re-exported libraries Make sure a re-exported setter is resolved even when no corresponding getter exists. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/07a52f67110885d204496cf6fa196ca783f6a48f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/vm/object.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hausner
4 years, 9 months ago (2016-03-22 23:11:44 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/1824213002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/1824213002/diff/1/runtime/vm/object.cc#newcode10807 runtime/vm/object.cc:10807: // LookupReExport() only finds returns objects that match ...
4 years, 9 months ago (2016-03-22 23:24:33 UTC) #4
hausner
Committed patchset #2 (id:20001) manually as 07a52f67110885d204496cf6fa196ca783f6a48f (presubmit successful).
4 years, 9 months ago (2016-03-22 23:27:20 UTC) #6
hausner
4 years, 9 months ago (2016-03-22 23:30:02 UTC) #7
Message was sent while issue was closed.
Thank you.

https://chromiumcodereview.appspot.com/1824213002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/1824213002/diff/1/runtime/vm/object.cc...
runtime/vm/object.cc:10807: // LookupReExport() only finds returns objects that
match the
On 2016/03/22 23:24:33, rmacnak wrote:
> "finds returns" -> "finds"

Yes.

Powered by Google App Engine
This is Rietveld 408576698