Mash: Show app icons in shelf based on the Widget's app icon

mash/task_viewer/task_viewer.cc

Index: mash/task_viewer/task_viewer.cc
diff --git a/mash/task_viewer/task_viewer.cc b/mash/task_viewer/task_viewer.cc
index 0e01a0059252f6f7d5f71d702cdd08be84ed4a6a..98d73bbe78b730808cace1dede166a3824015498 100644
--- a/mash/task_viewer/task_viewer.cc
+++ b/mash/task_viewer/task_viewer.cc
@@ -19,6 +19,8 @@
 #include "mojo/shell/public/cpp/connector.h"
 #include "mojo/shell/public/interfaces/shell.mojom.h"
 #include "ui/base/models/table_model.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/resources/grit/ui_resources.h"
 #include "ui/views/background.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/table/table_view.h"
@@ -87,6 +89,13 @@ class TaskViewerContents : public views::WidgetDelegateView,
     return base::ASCIIToUTF16("Tasks");
   }
 
+  gfx::ImageSkia GetWindowAppIcon() override {
+    // TODO(jamescook): Create a new .pak file for this app and use a custom

[msw, 2016/03/24 17:40:54]

Hmm, if this relies on chrome's image resources, we might want to pick another
image, or use a more strongly worded comment. Building mash:all shouldn't (and
hopefully still doesn't) build chrome's resource pak. Mash does rely on
ash_resources (see sysui_application's InitializeResourceBundle). Maybe this
could do the same with an icon in ash/resources/ash_resources.grd (for now).

[James Cook, 2016/03/25 15:39:28]

This icon isn't from Chrome or Ash. For better or worse it lives in
ui/resources, which is why I picked it. task_viewer only uses
views_mus_resources.pak, which includes ui_resource.pak. Updated the comment to
be more clear about what I meant by a new icon.

+    // icon, perhaps similar to the Chrome OS task viewer.
+    ResourceBundle& rb = ResourceBundle::GetSharedInstance();
+    return *rb.GetImageSkiaNamed(IDR_NOTIFICATION_SETTINGS);
+  }
+
   // Overridden from views::View:
   void Layout() override {
     gfx::Rect bounds = GetLocalBounds();